Refactor and add tests for MakePublicationTagCommand#727

Merged

caendesilva merged 70 commits intopublications-featurefrom refactor-MakePublicationTagCommand

Dec 3, 2022

Commits on Dec 3, 2022

Fix assumed typo in PHPDoc
caendesilva
committed
Replace self with static
caendesilva
committed
Remove unused parameter from getValuesForTagName helper
caendesilva
committed
Move down method to group tag related code together
caendesilva
committed
Update test annotation
caendesilva
committed
Break if stream fails
caendesilva
committed
Extract method
caendesilva
committed
Create MakePublicationTagCommandTest.php
caendesilva
committed
Add helper to mock the standard input stream
caendesilva
committed
Merge added tags with existing before save
caendesilva
committed
Implement base test
caendesilva
committed
Display the tag selections
caendesilva
committed
Add output expectations
caendesilva
committed
Test feed termination
caendesilva
committed
Clean up test code with teardown method
caendesilva
committed
Revert "Break if stream fails"
caendesilva
committed
Allow tag name to be passed as argument
caendesilva
committed
Extract method
caendesilva
committed
Replace ?? with if
caendesilva
committed
Fix test method names
caendesilva
committed
Display the tag name selection when using CLI argument
caendesilva
committed
Style the output
caendesilva
committed
Add a newline
caendesilva
committed
Add todo
caendesilva
committed
Remove unused import
caendesilva
committed
Move down method
caendesilva
committed
Display clickable filepath link
caendesilva
committed
Add todo
caendesilva
committed
Use shorter writeln syntax
caendesilva
committed
Add newline and style output
caendesilva
committed
Move variable declaration to just before first usage
caendesilva
committed
Use absolute paths for filesystem interactions
caendesilva
committed
Expect absolute path in output
caendesilva
committed
Convert 'sprintf()' call to concatenation
caendesilva
committed
Extract formatting helper to base class
caendesilva
committed
Refactor to use info comment helper
caendesilva
committed
Introduce local variable for the existing tags
caendesilva
committed
Shorten unit test code
caendesilva
committed
Fix and test conflict handling
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Extract reusable code to helper action
caendesilva
committed
Normalize output styling
caendesilva
committed
Extract helper methods
caendesilva
committed
Refactor to inline existingTags variable
caendesilva
committed
Refactor to use class properties instead of passing variables around
caendesilva
committed
Inline local variable
caendesilva
committed
Use the filesystem facade
caendesilva
committed
Inline local variable
caendesilva
committed
Split comma-separated values into multiple lines
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Clean up code
caendesilva
committed
Add method stub with same result as parent for more clear test
caendesilva
committed
Add a dynamic test command class
caendesilva
committed
Test the infoComment helper
caendesilva
committed
Allow extra info to be passed to infoComment helper
caendesilva
committed
Use the infoComment helper
caendesilva
committed
Inline local variable
caendesilva
committed
Introduce new local variable
caendesilva
committed
Extract helper
caendesilva
committed
Merge unnecessary local variable into single statement
caendesilva
committed
Inline local variable
caendesilva
committed
Swap to use safeHandle method
caendesilva
committed
Refactor to throw exception instead of returning error directly
caendesilva
committed
Extract method
caendesilva
committed
Shift down property assignment to helper method
caendesilva
committed
Shorten helper method name
caendesilva
committed
Shift down helper method call
caendesilva
committed
Revert "Shift down helper method call"
caendesilva
committed
Add todo
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed