Refactor the make publication command and add more tests for it#730

Merged

caendesilva merged 58 commits intopublications-featurefrom refactor-make-publication-command

Dec 4, 2022

Commits on Dec 4, 2022

Extract method for getting the sort direction
caendesilva
committed
Refactor to use the built in choice helper
caendesilva
committed
Copy over the option labels
caendesilva
committed
Update MakePublicationTypeCommandTest.php
caendesilva
committed
Add back default value
caendesilva
committed
Default to not add another field
caendesilva
committed
Extract method for getting the sort field
caendesilva
committed
Fix wrong order of expected and actual
caendesilva
committed
Refactor to use the built in choice helper
caendesilva
committed
Replace foreach loop with array_merge
caendesilva
committed
Import all used functions
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Extract helper methods
caendesilva
committed
Extract method to get the canonicalField
caendesilva
committed
Move up helper method
caendesilva
committed
Refactor to use the built in choice helper
caendesilva
committed
Cleanup foreach loop and use stronger comparisons
caendesilva
committed
Simplify selection logic
caendesilva
committed
Refactor foreach to use collection helpers
caendesilva
committed
Remove duplicate message
caendesilva
committed
Add temporary verbose check to see code coverage
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Extract getFieldType method
caendesilva
committed
Split comma-separated values into multiple lines
caendesilva
committed
Breaking: Add sequential array keys for the PublicationFieldType::TYPES constant
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Replace match with constant usage
caendesilva
committed
Add spacing between constants
caendesilva
committed
Output error instead of warning for forbidden value usage
caendesilva
committed
Update error message
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Refactor to use the built in choice helper
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Reformat file and reorder helper methods
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Extract helper method
caendesilva
committed
Refactor control flow to use return instead of temporary variable
caendesilva
committed
Use Laravel style error instead of Symfony
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Refactor to use the PublicationFieldType class instead of dynamic object
caendesilva
committed
Update expected order of field data
caendesilva
committed
Remove union typed int as inputs are always strings
caendesilva
committed
Extract method
caendesilva
committed
Use strict comparison
caendesilva
committed
Extract method
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Refactor to use Laravel validation for range validation
caendesilva
committed
Merge branch 'refactor-make-publication-command' of github.com:hydephp/develop into refactor-make-publication-command
caendesilva
committed
Apply fixes from StyleCI
StyleCIBot
committed
Merge branch 'refactor-ValidatingCommand' into refactor-make-publication-command
caendesilva
committed
Remove resolved todo
caendesilva
committed
Throw exceptions when validation fails in test
caendesilva
committed
Fix wrong array key
caendesilva
committed
Use gte instead of gt
caendesilva
committed
Update testing value to match actual value type
caendesilva
committed
Expect more outputs
caendesilva
committed
Revert "Refactor to use Laravel validation for range validation"
caendesilva
committed
Formatting
caendesilva
committed