Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate publication validation #736

Merged
merged 40 commits into from
Dec 7, 2022
Merged

Integrate publication validation #736

merged 40 commits into from
Dec 7, 2022

Conversation

caendesilva
Copy link
Member

Integrates code from #721

caendesilva and others added 30 commits December 6, 2022 12:52
@caendesilva @rgasch
Create ValidatePublicationTypeCommand.php
9620ff1 
Co-authored-by: rgasch <rgasch@gmail.com>
@caendesilva
Create ValidatePublicationTypeCommandTest.php
beef027
@caendesilva
Register the command
619a23b
@caendesilva
Update command PHPDoc
ec115c1
@caendesilva
Throw if there are no commands to validate
e05a50d
@caendesilva
Swap out handle for safeHandle
9142e50
@caendesilva
Test command with no publication types
67fb560
@caendesilva
Test command with invalid publication type
194ab25
@caendesilva
Set up method for test with publication types
6e867d3
@caendesilva @rgasch
Add getFieldRules method
85b3e5c 
Co-Authored-By: Robert Gasch <343614+rgasch@users.noreply.github.com>
@caendesilva @rgasch
Add getValidationRules and validate methods
b95ebe7 
Co-Authored-By: Robert Gasch <343614+rgasch@users.noreply.github.com>
@caendesilva
Use fieldRules as collection
82f515e
@caendesilva @rgasch
Add forget method to front matter class
d2d655d 
Co-Authored-By: Robert Gasch <343614+rgasch@users.noreply.github.com>
@caendesilva
Mark experimental method as internal
ade0925
@caendesilva
Update command output
cd2e5d7
@caendesilva
Refactor output to show checkmark next to publication if passed
f0cafcb
@caendesilva
Add more output assertions
101b92c
@caendesilva
Use singular test name
f2fe835
@StyleCIBot
Apply fixes from StyleCI
4e8ab43
@caendesilva
Test with verbose output
40f86a9
@caendesilva
Remove false positive and negative
adaf2a4
@caendesilva
Use the actual command signature instead of class constant in test
2e927c7
@caendesilva
Test command with invalid publication
20c1615
@caendesilva
Remove rouge fieldname and add newline
5132ef9
@caendesilva
Remove debug code
f75fa77
@caendesilva
Add code review comment
ba4aaab
@caendesilva
Update output
2d2b1a1
@StyleCIBot
Apply fixes from StyleCI
e5a33b2
@caendesilva
Add type annotation
5c2b112
@caendesilva
Merge branch 'integrate-publication-validation' of github.com:hydephp…
377918a 
…/develop into integrate-publication-validation
@caendesilva caendesilva marked this pull request as ready for review December 7, 2022 11:43
@caendesilva caendesilva merged commit 06ee91c into publications-feature Dec 7, 2022
@caendesilva caendesilva deleted the integrate-publication-validation branch December 7, 2022 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caendesilva @StyleCIBot