Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor generated publication views #807

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 5, 2023

Makes use of some placeholder views, using them as the source of truth for the generated publication type pages.

Will resolve the following code review comments

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #807 (eda9c02) into publications-feature (c5c2aef) will not change coverage.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature      #807     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   2914      1457   -1457     
==========================================================
  Files                         334       167    -167     
  Lines                        7316      3656   -3660     
==========================================================
- Hits                         7316      3656   -3660     
Impacted Files Coverage Δ
...rc/Framework/Actions/CreatesNewPublicationType.php 100.00% <0.00%> (ø)
...rc/Framework/Actions/CreatesNewPublicationType.php
...rc/Framework/Exceptions/BaseUrlNotSetException.php
packages/framework/src/Hyde.php
.../src/Framework/Factories/NavigationDataFactory.php
...mework/Features/Session/SessionServiceProvider.php
...c/Framework/Concerns/Internal/MockableFeatures.php
...rc/Framework/Features/Metadata/PageMetadataBag.php
...ework/src/Framework/Services/ValidationService.php
packages/framework/src/Pages/PublicationPage.php
... and 158 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 5, 2023 14:58
@caendesilva caendesilva merged commit e95acfd into publications-feature Jan 5, 2023
@caendesilva caendesilva deleted the refactor-generated-publication-views branch January 5, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants