Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up PublicationFieldTypes enum #833

Merged

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 14, 2023

Major changes:

  • Rename PublicationFieldTypes enum case Image to Media
  • Sort enum cases by ease of access (more or less)
  • Remove numeric rule from integer field type
  • Add string to default media type rules

@codecov
Copy link

codecov bot commented Jan 14, 2023

Codecov Report

Merging #833 (7afafad) into publications-feature (e14072e) will not change coverage.
The diff coverage is n/a.

❗ Current head 7afafad differs from pull request most recent head e374f4d. Consider uploading reports for the commit e374f4d to get more accurate results

@@                    Coverage Diff                     @@
##             publications-feature      #833     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   3060      1530   -1530     
==========================================================
  Files                         344       172    -172     
  Lines                        7638      3819   -3819     
==========================================================
- Hits                         7638      3819   -3819     
Impacted Files Coverage Δ
...ckages/publications/src/Validation/BooleanRule.php 100.00% <0.00%> (ø)
...publications/src/Actions/SeedsPublicationFiles.php
...ications/src/Actions/ValidatesPublicationField.php
...blications/src/Commands/MakePublicationCommand.php
.../publications/src/Models/PublicationFieldValue.php
...ackages/publications/src/PublicationFieldTypes.php
...ckages/publications/src/Validation/BooleanRule.php
...src/Framework/Exceptions/FileNotFoundException.php
...amework/src/Framework/Concerns/InvokableAction.php
...amework/src/Framework/Services/MarkdownService.php
... and 163 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva force-pushed the rename-publication-field-type-image-to-media branch from a2c10bc to 3053d9d Compare January 14, 2023 13:35
@caendesilva caendesilva changed the title Rename PublicationFieldTypes enum case Image to Media Clean up PublicationFieldTypes enum Jan 14, 2023
@caendesilva caendesilva force-pushed the rename-publication-field-type-image-to-media branch from 2df4e94 to ebe1a6e Compare January 14, 2023 15:10
@caendesilva caendesilva marked this pull request as ready for review January 14, 2023 15:27
@caendesilva caendesilva merged commit 260d854 into publications-feature Jan 14, 2023
@caendesilva caendesilva deleted the rename-publication-field-type-image-to-media branch January 14, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants