Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the publications validation command #836

Merged
merged 125 commits into from
Jan 15, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 15, 2023

Refactors to OOP and to buffer output instead of outputting in realtime. I also added execution time output, and got surprised that these refactors add virtually zero additional execution time (38ms avg instead of 36ms avg (spot checks))

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #836 (52b05ac) into publications-feature (6c769cb) will not change coverage.
The diff coverage is n/a.

@@                    Coverage Diff                     @@
##             publications-feature      #836     +/-   ##
==========================================================
  Coverage                  100.00%   100.00%             
+ Complexity                   3064      1560   -1504     
==========================================================
  Files                         342       171    -171     
  Lines                        7644      3868   -3776     
==========================================================
- Hits                         7644      3868   -3776     
Impacted Files Coverage Δ
...tions/src/Commands/ValidatePublicationsCommand.php 100.00% <0.00%> (ø)
...tions/src/Commands/ValidatePublicationsCommand.php
...es/framework/src/Console/Commands/DebugCommand.php
packages/framework/src/Foundation/HydeKernel.php
...mework/Features/XmlGenerators/BaseXmlGenerator.php
packages/framework/src/Facades/Meta.php
packages/framework/src/Support/Models/Route.php
.../framework/src/Framework/Services/AssetService.php
...rc/Framework/Exceptions/BaseUrlNotSetException.php
.../Framework/Services/DocumentationSearchService.php
... and 162 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 15, 2023 15:18
@caendesilva caendesilva merged commit 7f5876d into publications-feature Jan 15, 2023
@caendesilva caendesilva deleted the refactor-publications-validation branch January 15, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants