Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Change default DataCollection directory from _data to resources/collections #879

Merged
merged 3 commits into from
Jan 27, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Jan 27, 2023

Moving the (default) _data directory to resources/collections accomplishes two things:

  1. Makes the top level directory structure leaner (which also distinguishes it from page directories.
  2. The name collections makes more semantic sense for the usage, and I think the kind of data used fits within the resources domain too.
    The directory is configurable, so this is just the defaults.

Any existing sites will need to move their data before upgrading. This is as easy as mv -r _data resources/collections

Tracked in #877

…rces/collections

See #877

Any existing sites will need to move their data before upgrading. This is as easy as `mv -r _data resources/collections`
…develop into datacollections-package-updates
@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Merging #879 (a757943) into master (0c07b56) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master      #879     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1257      2514   +1257     
=============================================
  Files            147       294    +147     
  Lines           3288      6576   +3288     
=============================================
+ Hits            3288      6576   +3288     
Impacted Files Coverage Δ
...mework/Features/DataCollections/DataCollection.php 100.00% <ø> (ø)
.../DataCollections/DataCollectionServiceProvider.php 100.00% <100.00%> (ø)
...src/Framework/Exceptions/FileConflictException.php 100.00% <0.00%> (ø)
...es/framework/src/Framework/HydeServiceProvider.php 100.00% <0.00%> (ø)
.../packages/framework/src/Support/Facades/Render.php 100.00% <0.00%> (ø)
...ges/framework/src/Support/Filesystem/MediaFile.php 100.00% <0.00%> (ø)
...amework/src/Framework/Services/ChecksumService.php 100.00% <0.00%> (ø)
...amework/src/Framework/Actions/SourceFileParser.php 100.00% <0.00%> (ø)
...rk/Features/Blogging/Models/LocalFeaturedImage.php 100.00% <0.00%> (ø)
...rk/src/Framework/Features/Metadata/MetadataBag.php 100.00% <0.00%> (ø)
... and 139 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review January 27, 2023 19:40
@caendesilva caendesilva merged commit 511c7bd into master Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant