Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick base command changes from publications feature #892

Merged

Conversation

caendesilva
Copy link
Member

Follow up to #891, cherry pinging the refactors to the master branch

@caendesilva caendesilva marked this pull request as ready for review January 30, 2023 21:41
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #892 (1d3476b) into master (3684ce1) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master      #892     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1259      2530   +1271     
=============================================
  Files            146       292    +146     
  Lines           3291      6610   +3319     
=============================================
+ Hits            3291      6610   +3319     
Impacted Files Coverage Δ
.../src/Console/Commands/RebuildStaticSiteCommand.php 100.00% <100.00%> (ø)
...ackages/framework/src/Console/Concerns/Command.php 100.00% <100.00%> (ø)
.../packages/framework/src/Foundation/Application.php 100.00% <0.00%> (ø)
...res/Documentation/SemanticDocumentationArticle.php 100.00% <0.00%> (ø)
...tures/BuildTasks/PostBuildTasks/GenerateSearch.php 100.00% <0.00%> (ø)
develop/packages/framework/src/helpers.php 100.00% <0.00%> (ø)
...mework/src/Framework/Services/BuildTaskService.php 100.00% <0.00%> (ø)
...ork/Features/Metadata/Elements/MetadataElement.php 100.00% <0.00%> (ø)
...ork/src/Framework/Features/Templates/Homepages.php 100.00% <0.00%> (ø)
develop/packages/framework/src/Facades/Meta.php 100.00% <0.00%> (ø)
... and 138 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva merged commit bd7ad1f into master Jan 30, 2023
@caendesilva caendesilva deleted the cherry-pick-base-command-changes-from-publications-feature branch January 30, 2023 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants