Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create custom bootstrapper class for the yaml configuration feature #976

Merged
merged 48 commits into from
Feb 11, 2023

Conversation

caendesilva
Copy link
Member

@caendesilva caendesilva commented Feb 11, 2023

Since this must be run before service providers, and since their execution order is not guaranteed, this task makes more sense as a bootstrapper class. This change creates a custom bootstrapper class, and inlines the YamlConfigurationService into it.

Furthermore, since the ConfigurationServiceProvider now is no longer coupled to this feature, we can register it in the app config instead of the HydeServiceProvider.

This will further decouple the HydeServiceProvider allowing it to function more in isolate, further resolving #939.

caendesilva and others added 24 commits February 11, 2023 19:43
While protected it's so critical we do want to regression test it
…s vendor interface is internal

This reverts commit 6dd47af.
@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #976 (2829b8a) into master (7d76d69) will not change coverage.
The diff coverage is 100.00%.

@@              Coverage Diff              @@
##              master      #976     +/-   ##
=============================================
  Coverage     100.00%   100.00%             
- Complexity      1265      2530   +1265     
=============================================
  Files            149       300    +151     
  Lines           3334      6674   +3340     
=============================================
+ Hits            3334      6674   +3340     
Impacted Files Coverage Δ
...ndation/Providers/ConfigurationServiceProvider.php 100.00% <ø> (ø)
...ackages/framework/src/Foundation/ConsoleKernel.php 100.00% <100.00%> (ø)
.../src/Foundation/Services/LoadYamlConfiguration.php 100.00% <100.00%> (ø)
...es/framework/src/Framework/HydeServiceProvider.php 100.00% <100.00%> (ø)
...s/framework/src/Support/Filesystem/ProjectFile.php 100.00% <0.00%> (ø)
...res/DataCollections/Facades/MarkdownCollection.php 100.00% <0.00%> (ø)
...ork/src/Foundation/Concerns/ForwardsFilesystem.php 100.00% <0.00%> (ø)
.../src/Framework/Concerns/RegistersFileLocations.php 100.00% <0.00%> (ø)
...ackages/framework/src/Console/Concerns/Command.php 100.00% <0.00%> (ø)
...mework/Exceptions/UnsupportedPageTypeException.php 100.00% <0.00%> (ø)
... and 144 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@caendesilva caendesilva marked this pull request as ready for review February 11, 2023 21:00
@caendesilva caendesilva merged commit 1230fef into master Feb 11, 2023
@caendesilva caendesilva deleted the create-bootstrapper-class-for-yaml-configuration branch February 11, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants