Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Category component should not be included if category is not set in front matter #230

Closed
caendesilva opened this issue May 2, 2022 · 1 comment · Fixed by #241
Closed

Bug: Category component should not be included if category is not set in front matter #230

caendesilva opened this issue May 2, 2022 · 1 comment · Fixed by #241

Comments

@caendesilva
Copy link
Member

caendesilva commented May 2, 2022 •
edited
Loading

Screenshot from a post

image

Caused because the category property was not nullable, and instead fell back to an empty string in the MarkdownPost class.

$this->category = $this->matter['category'] ?? '';
@caendesilva
Copy link
Member Author

caendesilva commented May 2, 2022 •
edited
Loading

Also, in excerpt
image
remove comma if author is not set

@caendesilva caendesilva mentioned this issue May 2, 2022
Closed
caendesilva added a commit that referenced this issue May 2, 2022
@caendesilva
Make category nullable, fixes #230
2c66a7d
@caendesilva caendesilva linked a pull request May 2, 2022 that will close this issue
Fix bugs in article and excerpts not fluently constructing descriptions #241
Merged
@caendesilva caendesilva mentioned this issue May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bugs in article and excerpts not fluently constructing descriptions hydephp/framework
1 participant
@caendesilva