-
Notifications
You must be signed in to change notification settings - Fork 54
Improve hydro_deploy build error reporting, fix stageleft windows paths #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These test failures are strange, it seems that the |
0c4ca87
to
a4454e1
Compare
@shadaj I also can't repro (anymore) on my local windows, lol. Removing the CI for now and testing more |
I wonder if we need to be using |
a4454e1
to
679ad44
Compare
Actually can reproduce again locally. Build seems to be broken in typenum paholg/typenum#195 Will merge this and continue |
Seems like OUT_DIR is getting mutilated: |
|
Yep, https://stackoverflow.com/questions/50322817/how-do-i-remove-the-prefix-from-a-canonical-windows-path. We canonicalize the src path before using it as the current dir for the command. |
No description provided.