Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hydro_deploy)!: replace async-channel with tokio::sync::mpsc::unbounded_channel #1356

Merged
merged 1 commit into from
Jul 18, 2024
Merged

refactor(hydro_deploy)!: replace async-channel with tokio::sync::mpsc::unbounded_channel #1356

merged 1 commit into from
Jul 18, 2024

Conversation

MingweiSamuel
Copy link
Member

@MingweiSamuel MingweiSamuel commented Jul 17, 2024 •
edited
Loading

Depends on #1339

@MingweiSamuel MingweiSamuel changed the title refactor(hydro_deploy): replace async-channel dep with tokio::sync::mpsc::unbounded_channel refactor(hydro_deploy): replace async-channel with tokio::sync::mpsc::unbounded_channel Jul 17, 2024
@MingweiSamuel MingweiSamuel changed the title refactor(hydro_deploy): replace async-channel with tokio::sync::mpsc::unbounded_channel refactor(hydro_deploy)!: replace async-channel with tokio::sync::mpsc::unbounded_channel Jul 17, 2024
@MingweiSamuel MingweiSamuel requested a review from shadaj July 17, 2024 23:40
MingweiSamuel added a commit that referenced this pull request Jul 18, 2024
@MingweiSamuel
refactor(hydro_deploy)!: replace some uses of tokio::sync::RwLock w…
141eae1 
…ith `std::sync::Mutex` #430 (3/3) (#1339)

`std::sync::Mutex` should be used as long as the lock is not held across
any `.await` yield points.

STACK: #1338 ~~#1341~~

#1356 next
@MingweiSamuel
no-async-channel works except for python
8730acd 
no more async-channel

cleanup verbose qualified names
@MingweiSamuel MingweiSamuel enabled auto-merge (squash) July 18, 2024 02:03
@MingweiSamuel MingweiSamuel merged commit 90d51ec into hydro-project:main Jul 18, 2024
12 of 13 checks passed
MingweiSamuel added a commit that referenced this pull request Jul 18, 2024
@MingweiSamuel
refactor(hydro_deploy)!: replace async-channel with `tokio::sync::m…
e9a87eb 
…psc::unbounded_channel` (#1356)

Depends on #1339

We could make the publicly facing `stdout`, `stderr` APIs return `impl Stream<Output = String>` in the future, maybe
MingweiSamuel added a commit that referenced this pull request Jul 18, 2024
@MingweiSamuel
refactor(hydro_deploy)!: replace async-channel with `tokio::sync::m…
6039078 
…psc::unbounded_channel` (#1356)

Depends on #1339

We could make the publicly facing `stdout`, `stderr` APIs return `impl Stream<Output = String>` in the future, maybe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadaj shadaj shadaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MingweiSamuel @shadaj