feat(hydro_deploy): improve progress UX by collapsing nested groups #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hydroflow with
|
| Latest commit: |
fb24258
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://91e9e1be.hydroflow.pages.dev |
| Branch Preview URL: | https://pr1411.hydroflow.pages.dev |
|
Output example: 
|
shadaj
force-pushed
the
pr1411
branch
2 times, most recently
from
7e187fe to
9494ead
Compare
Now, when a group only has a single active task, we skip printing a line for the group itself and instead collapse its information into the line for the inner task (recursively as necessary). This allows us to show more fine grained progress without overflowing the console.
|
Amazing I was thinking to do this |
Comment on lines
+84
to
+91
| format!( | ||
| " ({}/{}/{})", | ||
| finished_count, | ||
| started_count, | ||
| queued_count + finished_count + started_count | ||
| ) | ||
| } | ||
| None => format!(" ({}/{}/?)", finished_count, started_count), |
There was a problem hiding this comment.
Hmm maybe a format like {}+{}/{} would be more understandable? bikeshed
MingweiSamuel
approved these changes
Aug 22, 2024
shadaj
added a commit
that referenced
this pull request
Mar 11, 2025
…1411) Now, when a group only has a single active task, we skip printing a line for the group itself and instead collapse its information into the line for the inner task (recursively as necessary). This allows us to show more fine grained progress without overflowing the console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, when a group only has a single active task, we skip printing a line for the group itself and instead collapse its information into the line for the inner task (recursively as necessary). This allows us to show more fine grained progress without overflowing the console.