Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hydro_deploy)!: rename integration crates to drop CLI references #1413

Merged
merged 2 commits into from
Aug 22, 2024

Conversation

shadaj
Copy link
Member

@shadaj shadaj commented Aug 22, 2024

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Aug 22, 2024

Deploying hydroflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 8122caa
Status: ✅  Deploy successful!
Preview URL: https://c2d94f5b.hydroflow.pages.dev
Branch Preview URL: https://pr1413.hydroflow.pages.dev

View logs

@shadaj shadaj changed the title refactor!(hydro_deploy): rename integration crates to drop CLI references refactor(hydro_deploy)!: rename integration crates to drop CLI references Aug 22, 2024
@shadaj shadaj requested a review from MingweiSamuel August 22, 2024 17:03
Copy link
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to follow
https://github.com/hydro-project/hydroflow/blob/main/RELEASING.md#addendum-moving-crates
For hydroflow_deploy_integration and hydroflow_plus_deploy

@shadaj shadaj force-pushed the pr1413 branch 3 times, most recently from f7210af to 9eca654 Compare August 22, 2024 17:34
Copy link
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shadaj shadaj merged commit 0a465e5 into main Aug 22, 2024
16 checks passed
@shadaj shadaj deleted the pr1413 branch August 22, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants