Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: getLines support named section markers, fix #1320 #1555

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

MingweiSamuel
Copy link
Member

@MingweiSamuel MingweiSamuel commented Nov 8, 2024

Fix #1320 suggested in #1318 (review)

@MingweiSamuel MingweiSamuel changed the title docs code sections docs: getLines sections Nov 8, 2024
@MingweiSamuel MingweiSamuel force-pushed the docs-code-sections branch 2 times, most recently from 7c41d33 to 5b0039b Compare November 8, 2024 16:11
@MingweiSamuel MingweiSamuel requested a review from shadaj November 8, 2024 16:13
@MingweiSamuel MingweiSamuel marked this pull request as ready for review November 8, 2024 16:13
@MingweiSamuel MingweiSamuel changed the title docs: getLines sections docs: getLines named sections Nov 8, 2024
@MingweiSamuel MingweiSamuel changed the title docs: getLines named sections docs: getLines named sections, fix #1320 Nov 8, 2024
@MingweiSamuel MingweiSamuel changed the title docs: getLines named sections, fix #1320 docs: getLines support named section markers, fix #1320 Nov 8, 2024
Copy link
Member

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice this is so awesome!

@MingweiSamuel MingweiSamuel merged commit 5c53e12 into hydro-project:main Nov 8, 2024
19 checks passed
@MingweiSamuel MingweiSamuel deleted the docs-code-sections branch November 8, 2024 21:20
@MingweiSamuel MingweiSamuel added the documentation Improvements or additions to documentation label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use code comment markers instead of line numbers to include code snipets in book
2 participants