Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows build #584

Merged
merged 2 commits into from
Apr 13, 2023
Merged

Conversation

MingweiSamuel
Copy link
Member

No description provided.

@MingweiSamuel MingweiSamuel requested a review from zzlk April 13, 2023 05:31
@zzlk
Copy link
Contributor

zzlk commented Apr 13, 2023

cetra3/tmq#17

@zzlk
Copy link
Contributor

zzlk commented Apr 13, 2023

should we add a cross-compile-to-windows CI target to catch stuff like this?

@MingweiSamuel MingweiSamuel merged commit 5aa96c4 into hydro-project:main Apr 13, 2023
@MingweiSamuel
Copy link
Member Author

MingweiSamuel commented Apr 13, 2023

Ended up just adding a --features=kvs_bench if you want to compile/run kvs_bench, off by default

MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this pull request Apr 13, 2023
MingweiSamuel added a commit that referenced this pull request Apr 13, 2023
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this pull request Jan 24, 2024
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this pull request Jan 24, 2024
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this pull request Jan 25, 2024
nickjiang2378 pushed a commit to nickjiang2378/hydroflow that referenced this pull request Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants