Scheduler spins when new tick triggeres Irrelevant stateful operator in stratum 0 (bug code) #961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MingweiSamuel
force-pushed
the
schedule-bug
branch
from
b760864 to
55d27e0
Compare
MingweiSamuel
changed the title
MingweiSamuel
changed the title
|
Could we just re-implement persist and other stateful operators only to emit if they receive input? |
Closed
This seems really messy from a semantics standpoint. We expect the output of persist to be monotonic wrt time for a bunch of optimizations we want. |
|
Yes it would work in some situations (push based) but not in others (pull based) |
|
let mut df = hydroflow_syntax! {
source_iter([1])
-> next_stratum()
-> persist()
-> defer_tick_lazy()
-> null();
}; |
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this pull request
Apr 23, 2024
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this pull request
Apr 23, 2024
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this pull request
Apr 23, 2024
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this pull request
Apr 24, 2024
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this pull request
Apr 24, 2024
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this pull request
Apr 24, 2024
MingweiSamuel
added a commit
to MingweiSamuel/hydroflow
that referenced
this pull request
Apr 24, 2024
… (hydro-project#1171) fixes the added tests failing in the previous commit
MingweiSamuel
added a commit
that referenced
this pull request
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
%%{init:{'theme':'base','themeVariables':{'clusterBkg':'#ddd','clusterBorder':'#888'}}}%% flowchart TD classDef pullClass fill:#8af,stroke:#000,text-align:left,white-space:pre classDef pushClass fill:#ff8,stroke:#000,text-align:left,white-space:pre classDef otherClass fill:#fdc,stroke:#000,text-align:left,white-space:pre linkStyle default stroke:#aaa 1v1[\"(1v1) <code>source_iter([1])</code>"/]:::pullClass 2v1[\"(2v1) <code>union()</code>"/]:::pullClass 3v1[\"(3v1) <code>persist()</code>"/]:::pullClass 4v1[\"(4v1) <code>fold(|| 0, |accum, x| *accum += x)</code>"/]:::pullClass 5v1[\"(5v1) <code>defer_tick_lazy()</code>"/]:::pullClass 6v1[\"(6v1) <code>filter(|_| false)</code>"/]:::pullClass 7v1[/"(7v1) <code>tee()</code>"\]:::pushClass 8v1[/"(8v1) <code>null()</code>"\]:::pushClass 9v1["(9v1) <code>handoff</code>"]:::otherClass 10v1["(10v1) <code>handoff</code>"]:::otherClass 11v1["(11v1) <code>handoff</code>"]:::otherClass 1v1-->2v1 6v1-->7v1 5v1-->6v1 4v1-->9v1 3v1-->10v1 2v1-->3v1 7v1-->8v1 7v1-->11v1 9v1--o5v1; linkStyle 8 stroke:red 10v1--x4v1; linkStyle 9 stroke:red 11v1-->2v1 subgraph sg_1v1 ["sg_1v1 stratum 0"] 1v1 2v1 3v1 subgraph sg_1v1_var_double ["var <tt>double</tt>"] 3v1 end subgraph sg_1v1_var_items ["var <tt>items</tt>"] 2v1 end end subgraph sg_2v1 ["sg_2v1 stratum 1"] 4v1 subgraph sg_2v1_var_double ["var <tt>double</tt>"] 4v1 end end subgraph sg_3v1 ["sg_3v1 stratum 0"] 5v1 6v1 7v1 8v1 subgraph sg_3v1_var_double ["var <tt>double</tt>"] 5v1 6v1 7v1 end endmermaid.live