Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run CI on stable Rust rather than latest nightly #1587

Closed
shadaj opened this issue Nov 22, 2024 · 0 comments
Closed

Run CI on stable Rust rather than latest nightly #1587

shadaj opened this issue Nov 22, 2024 · 0 comments
Assignees
@MingweiSamuel
Labels
testing

Comments

@shadaj
Copy link
Member

shadaj commented Nov 22, 2024

Some of our crates (hydroflow at least) are expected to compile on stable Rust. We should run these compilation checks in CI.

In addition, running lints on latest-nightly seems to not be worth the effort, since it just fails every build on main and we pin our nightly version in the repo and templates anyways. So we can reduce the CI burden there.
@shadaj shadaj changed the title Run CI on stable rust rather than latest nightly Run CI on stable Rust rather than latest nightly Nov 22, 2024
@MingweiSamuel MingweiSamuel self-assigned this Dec 6, 2024
@MingweiSamuel MingweiSamuel mentioned this issue Dec 7, 2024
Merged
MingweiSamuel added a commit that referenced this issue Dec 10, 2024
@MingweiSamuel
feat(hydroflow)!: remove import!, fix #1110 (#1600)
f2a4bee 
in prep for rust stable #1587

No good way to resolve the source file paths on stable

No way to get good diagnostics on external files in general, at all

rust-lang/rfcs#3200
This was referenced Dec 10, 2024
Closed
Merged
MingweiSamuel added a commit that referenced this issue Dec 12, 2024
@MingweiSamuel
refactor!: use cfg(nightly) instead of feature, remove -Z flag, u…
251b103 
…se `Diagnostic::try_emit` (#1606)

Previous PR (#1587) website build did not work because `panic = "abort"`
is set on wasm, leading to aborts for `proc_macro2::Span::unwrap()`
calls.

All tests except trybuild seem to pass on stable, WIP #1587 next

BREAKING CHANGE: replaces `hydroflow_lang::diagnostic::Diagnostic::emit`
with `try_emit`
BREAKING CHANGE: removes features: `hydroflow/nightly`,
`hydroflow_datalog/diagnostics`, `hydroflow_datalog_core/diagnostics`,
`hydroflow_lang/diagnostics`, `hydroflow_macro/diagnostics`,
`hydroflow_plus/diagnostics`.
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Dec 12, 2024
@MingweiSamuel
ci: test latest stable (instead of nightly), fix #hydro-project#1587
ad0a402
MingweiSamuel added a commit to MingweiSamuel/hydroflow that referenced this issue Dec 12, 2024
@MingweiSamuel
fixup! ci: test latest stable (instead of nightly), fix #hydro-projec…
bde3714 
…t#1587
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MingweiSamuel MingweiSamuel

Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build!: compile and run CI on stable, fix #1587 MingweiSamuel/hydroflow
2 participants
@shadaj @MingweiSamuel