Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hydroflow_plus)!: implicitly apply default optimizations #1557

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Conversation

shadaj
Copy link
Member

@shadaj shadaj commented Nov 8, 2024

This also changes the behavior of with_default_optimize to be terminal, if users want to apply optimizations after these they should explicitly invoke the optimizations.

This also changes the behavior of `with_default_optimize` to be terminal, if users want to apply optimizations after these they should explicitly invoke the optimizations.
Copy link

cloudflare-workers-and-pages bot commented Nov 8, 2024

Deploying hydroflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7e99e09
Status: ✅  Deploy successful!
Preview URL: https://79cb5db5.hydroflow.pages.dev
Branch Preview URL: https://pr1557.hydroflow.pages.dev

View logs

@shadaj shadaj requested a review from MingweiSamuel November 8, 2024 18:24
Copy link
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What D: LocalDeploy<'a> options are there and when would you choose each? DeployRuntime vs SingleProcessGraph?

@shadaj
Copy link
Member Author

shadaj commented Nov 8, 2024

What D: LocalDeploy<'a> options are there and when would you choose each? DeployRuntime vs SingleProcessGraph?

Yeah those are the two options, LocalDeploy / SingleProcessGraph is kinda legacy at this point for the macro compilation approach versus trybuild. So in the future we may end up just dropping it.

@shadaj shadaj merged commit 8d8b4b2 into main Nov 8, 2024
14 checks passed
@shadaj shadaj deleted the pr1557 branch November 8, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants