refactor(paxos): generalize quorum logic #1583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying hydroflow with
|
| Latest commit: |
e20aaee
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://81b55f4e.hydroflow.pages.dev |
| Branch Preview URL: | https://pr1583.hydroflow.pages.dev |
This was referenced Nov 21, 2024
shadaj
force-pushed
the
pr1583
branch
3 times, most recently
from
bf8b7f8 to
3c80c56
Compare
shadaj
force-pushed
the
pr1583
branch
3 times, most recently
from
2f70418 to
bbdbd01
Compare
shadaj
commented
Nov 21, 2024
| let c_new_payloads_when_restart = restart_this_tick.clone().flat_map(q!(move |_| (0 | ||
| ..num_clients_per_node) | ||
| .map(move |i| ( | ||
| (CLUSTER_SELF_ID.raw_id * (num_clients_per_node as u32)) + i as u32, |
There was a problem hiding this comment.
Oops, multiple clients would clobber each-other's keys.
shadaj
force-pushed
the
pr1583
branch
3 times, most recently
from
3d4d628 to
091e6a1
Compare
|
Merging without review since this didn't touch core Paxos logic other than extracting common logic David is busy with a paper. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.