Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(hydroflow_plus): add initial docs on consistency and safety #1592

Merged
merged 1 commit into from
Dec 4, 2024
Merged

docs(hydroflow_plus): add initial docs on consistency and safety #1592

merged 1 commit into from
Dec 4, 2024

Conversation

shadaj
Copy link
Member

@shadaj shadaj commented Dec 3, 2024 •
edited
Loading

No description provided.

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Dec 3, 2024 •
edited
Loading

Deploying hydroflow with  Cloudflare Pages  Cloudflare Pages

Latest commit: 849d46b
Status: ✅  Deploy successful!
Preview URL: https://3c113392.hydroflow.pages.dev
Branch Preview URL: https://pr1592.hydroflow.pages.dev

View logs

@shadaj shadaj force-pushed the pr1592 branch 2 times, most recently from 2739c69 to 5079edb Compare December 4, 2024 00:08
MingweiSamuel
MingweiSamuel reviewed Dec 4, 2024
View reviewed changes
Copy link
Member

@MingweiSamuel MingweiSamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a note about the determinism of rust closure UDFs too? map(q!(|_| random())) would slip through right now?

hydroflow_plus_test/src/cluster/mod.rs Outdated Show resolved Hide resolved
docs/docs/hydroflow_plus/consistency.mdx Outdated Show resolved Hide resolved
@shadaj shadaj force-pushed the pr1592 branch 3 times, most recently from 595d3f9 to 3680cf3 Compare December 4, 2024 00:39
@shadaj shadaj merged commit 6c3adab into main Dec 4, 2024
27 checks passed
@shadaj shadaj deleted the pr1592 branch December 4, 2024 01:17
@shadaj shadaj mentioned this pull request Dec 5, 2024
Closed
@MingweiSamuel MingweiSamuel added the documentation Improvements or additions to documentation label Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MingweiSamuel MingweiSamuel MingweiSamuel approved these changes

@jhellerstein jhellerstein Awaiting requested review from jhellerstein

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shadaj @MingweiSamuel