Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(hydroflow_plus): use match_box macro to compile on stable #1597

Merged
merged 2 commits into from
Dec 6, 2024
Merged

refactor(hydroflow_plus): use match_box macro to compile on stable #1597

merged 2 commits into from
Dec 6, 2024

Conversation

MingweiSamuel
Copy link
Member

@MingweiSamuel MingweiSamuel commented Dec 6, 2024 •
edited
Loading

question is whether to pull match_box into the monorepo or leave it in https://github.com/hydro-project/matchbox

@MingweiSamuel MingweiSamuel requested a review from shadaj December 6, 2024 19:52
shadaj
shadaj approved these changes Dec 6, 2024
View reviewed changes
Copy link
Member

@shadaj shadaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh this is super nice! I vote leave matchbox in a separate repo, since I think it's less likely to need to move in lock-step (like rust-sitter).

@MingweiSamuel MingweiSamuel merged commit 9ea5f06 into hydro-project:main Dec 6, 2024
13 checks passed
@MingweiSamuel MingweiSamuel deleted the matchbox-2 branch December 6, 2024 20:45
@shadaj shadaj mentioned this pull request Dec 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shadaj shadaj shadaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MingweiSamuel @shadaj