Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PatternEditor: invalid note placement with resolution set to off #2015

Closed
theGreatWhiteShark opened this issue Aug 15, 2024 · 2 comments
Closed
Labels
Milestone

Comments

@theGreatWhiteShark
Copy link
Contributor

theGreatWhiteShark commented Aug 15, 2024

Hydrogen version * : 1.1.0 - 1.2.3


While other resolutions work just fine, something is literally off when choosing off in the combo box.

On larger zoom levels note placement seems kinda arbitrary but reproducible. At least it does not honor tick positions but yields uniform distances between individual notes.

patternEditor

On smaller zoom levels there is a systematic offset that scales with the x position of the note.

@theGreatWhiteShark theGreatWhiteShark added this to the 1.2.4 milestone Aug 15, 2024
@theGreatWhiteShark
Copy link
Contributor Author

Cursor does look weird as well for resolution set to off.

patternEditor_cursor

theGreatWhiteShark added a commit to theGreatWhiteShark/hydrogen that referenced this issue Aug 16, 2024
drawing grid lines with resolution set to `off` was off. Instead of introducing two new grid lines in the space between those already existing for 1/64 (because resolution increased to 1/64*3=1/192) just a single line was added. Right in the center where no note could be added
theGreatWhiteShark added a commit that referenced this issue Aug 18, 2024
…off-2015

PatternEditor: Fix editing with resolution set to `off` (#2015)
@theGreatWhiteShark
Copy link
Contributor Author

Closed with #2016

theGreatWhiteShark added a commit that referenced this issue Aug 18, 2024
drawing grid lines with resolution set to `off` was off. Instead of introducing two new grid lines in the space between those already existing for 1/64 (because resolution increased to 1/64*3=1/192) just a single line was added. Right in the center where no note could be added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant