-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Float note positions and tuplets #1251
base: development
Are you sure you want to change the base?
Float note positions and tuplets #1251
Conversation
…fractional mismatch, make some old formulas more understandable + doc comments
…tion instead of tick position
…ion or tuplet ratio
…resent notes in that tick position
…ution internal members directly
…to delete or add a new one on mouse click
Along with many things to discuss, there is the printing precision of For the moment I am using 10 significant digits for the XML |
b5bf419
to
3101b64
Compare
I see Windows is not building the last commit. I have no idea, there were very few changes (maybe function |
Hey @oddtime , I think this was due to one of my commits which slipped into master and caused the Windows builds to break. |
Hey @oddtime, I'm currently working on a larger patch of Hydrogen's AudioEngine to make it support arbitrary tempo changes. Unfortunate for me but lucky for you, this will include changing the tick type from integer to float. At first, there will be a compatibility layer making everything except AudioEngine and Sampler still see the ticks as integers but from the engine perspective there won't be much missing to support arbitrary tuplets. |
Hi @theGreatWhiteShark |
Well, at least the AudioEngine stuff I'm doing right now is more or less orthogonal to your PR. But there was indeed quite some progress during the last year. |
@theGreatWhiteShark is your patch of Hydrogen's AudioEngine fully merged now? Thanks |
Hmm. So, the audio engine already uses double precision ticks internally. That's merged. But there are still a number of glitches due to me getting some things not right the first time and some conceptional legacy still prevailing. I'm in the process of fixing these things and make the engine (hopefully) run as smooth as it gets. It still needs some more testing but it feels like its almost done. https://github.com/theGreatWhiteShark/hydrogen/tree/phil-introduce-transport-position That aside, |
After some tests I am pushing the experimental work (in progress) with
double
note tick positions.I have not implemented a class for note positions, just using the 192/whole note resolution as a unit.
It includes the minimal gui used to test tuplets in #1127 that can be used to input fractional position notes.
Note: reloading a file using other branch versions, transforms all fractional positions to zero (not the fractional part but the number indeed), because of
QLocale::toInt()
inreadXMLInt()
Note: piano roll is not working for tuplets