xsd: allow unbound number of notes in pattern #1842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a limitation in the XSD file that set the maximum number of allow notes within a pattern to `1000`. This number can easily be reached by setting resolution to `off` and filling all notes for a couple of instruments. Curiously, Qt treated this number wrong and also deemed paterns containing more than `100` notes as invalid. Once considered invalid, Hydrogen thinks this pattern is of a legacy format. But since it is not, loading partially fails. I removed the constraint for a maximum number of notes. fixes hydrogen-music#1827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a limitation in the XSD file that set the maximum number of allow notes within a pattern to
1000. This number can easily be reached by setting resolution tooffand filling all notes for a couple of instruments. Curiously, Qt treated this number wrong and also deemed paterns containing more than100notes as invalid.Once considered invalid, Hydrogen thinks this pattern is of a legacy format. But since it is not, loading partially fails.
I removed the constraint for a maximum number of notes.
fixes #1827