Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been looking at #411 and tried to fix Issues with incorrect MIDI values. It seems that Hydrogen sends wrong MIDI note (24 tones lower than it should) - for example it sends 12 instead of 36. I fixed that and I hope I hadn't break anything else.
Acceptance criteria
instrument being played. That Note On message should be followed by
Note Off message with the same pitch.
Eg. playing instrument with note 36 should play note 36 (C3).
n-th instrument should respond to NoteOn messages
with pitch set to 35+n.
Eg. Note On with pitch 47 (B3) should trigger 12th instrument
each instrument should respond to Note On messages with pitch
set to MIDI note assigned to that instrument.
Eg. Note On with pitch 56 (G#4) should trigger instrument that
has MIDI note set to 56.
correct pitches (i.e. the same pitches that are assigned to
respective instruments).
Eg. every note from instrument with MIDI note 38 should
have pitch 38 (D3) in output MIDI file.
That case should be covered by automated tests
Test results
Hydrogen provides 4 MIDI drivers: ALSA, CoreMIDI, Jack and PortMIDI. Unfortunately, I've been only able to test CoreMIDI, so I need your help! Please write your test results along with driver name in comment, and I'll update the table:
In my testing I've been using MidiPipe utility:
I think there are similar utilities for other platforms.
Note names assume C5 = 60