Names instead of IDs on cover #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll do my best to test and make suggestions in the next days, thanks! |
|
I recommend going through the four commits one by one, that makes the changes easier to understand. It looks worse than it is ;). |
b100dian
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
Looks good, now that I have read the changes commit for commit.
One thing I think we should have in mind from now on is that this javascript code is executed in the webview, so you can actually use Promises and destructuring to make the code a little simpler (adding callbacks was what I did too, so this is not in the scope of this PR).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously: if a room had no name, the first member's user ID was used as handle on the cover, e.g.
@x:matrix.org.Now: unnamed rooms are shown as a list of their member's display names, e.g.
Joe, Jane, and Jim.The code is annoyingly complex and probably not very efficient, but I didn't find a way around it. It has to access two databases asynchronously and merge the results...
Fixes #52.