-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add elevation and slope properties #151
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
…ydro into altitude-slope-gis
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tests are failing maybe because of Planetary Computer's breaking changes on June 6th. It's probably a quick fix if someone needs this PR quickly or else, I will be back at work in 2 weeks to fix it before merging. |
They changed a URL and our security hardening failed the builds as a result. I'll go about unblocking them. |
Pull Request Checklist:
This PR addresses an already opened issue (for bug fixes / features)
(If applicable) Documentation has been added / updated (for bug fixes / features).
(If applicable) Tests have been added.
CHANGELOG.rst has been updated (with summary of main changes).
number
) and pull request (:pull:number
) has been added.What kind of change does this PR introduce?
Does this PR introduce a breaking change?
No
Other information: