Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the French documentation #163

Merged
merged 16 commits into from
Jul 18, 2024
Merged

Update the French documentation #163

merged 16 commits into from
Jul 18, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Jul 17, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • This is a first batch of translations that were missing from the current documentation.
  • I've changed the Makefile to create files for the Docstrings, but I haven't gone around to translate them yet.
  • The script to help with auto-translations has been added to a new CI folder.
  • This PR is only for the translations themselves, but we could use the new translator script to automate most of the process in a GitHub workflow eventually.
  • This partly addresses Document the Translation process #63, but not fully.

Does this PR introduce a breaking change?

Other information:

  • I don't think that we need to translate the ChangeLog?

@RondeauG RondeauG changed the title Frenchdocs Update to the French documentation Jul 17, 2024
@RondeauG RondeauG changed the title Update to the French documentation Update the French documentation Jul 17, 2024
@github-actions github-actions bot added the CI label Jul 17, 2024
@Zeitsperre
Copy link
Collaborator

@RondeauG

/home/docs/checkouts/readthedocs.org/user_builds/xhydro-fr/checkouts/163/docs/notebooks/climate_change.ipynb:941: WARNING: File not found: 'notebooks/local_Frequency_analysis.ipynb'

@RondeauG
Copy link
Collaborator Author

@Zeitsperre I see that quite a few translations get ignored. Would you know why?

Zeitsperre
Zeitsperre approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@Zeitsperre Zeitsperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive

CI/translator.py Show resolved Hide resolved
CONTRIBUTING.rst Outdated Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved for additional tests label Jul 18, 2024
RondeauG and others added 2 commits July 18, 2024 14:12
@RondeauG @Zeitsperre
Update CONTRIBUTING.rst
49fc5a7 
Co-authored-by: Trevor James Smith <10819524+Zeitsperre@users.noreply.github.com>
@RondeauG
retranslate last changes
69634e6
@RondeauG RondeauG merged commit 85fae0e into main Jul 18, 2024
19 checks passed
@RondeauG RondeauG deleted the frenchdocs branch July 18, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zeitsperre Zeitsperre Zeitsperre approved these changes

@TC-FF TC-FF Awaiting requested review from TC-FF

Assignees
No one assigned
Labels
approved Approved for additional tests CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RondeauG @Zeitsperre