Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update cookiecutter, address ruff violations, integrate xdatasets conda package #164

Merged
merged 12 commits into from
Jul 18, 2024
Merged

Update cookiecutter, address ruff violations, integrate xdatasets conda package #164

merged 12 commits into from
Jul 18, 2024

Conversation

Zeitsperre
Copy link
Collaborator

@Zeitsperre Zeitsperre commented Jul 17, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • Fast-forwards the cookiecutter to the latest commit
  • Adjust workflow permissions and versions
  • Replace PyPI-sourced xdatasets with the new conda-forge package
  • Addressed several ruff violations, added exceptions as needed

Does this PR introduce a breaking change?

Not really. The conda recipe no longer relies on PyPI!

@Zeitsperre Zeitsperre requested a review from RondeauG July 17, 2024 21:08
@github-actions github-actions bot added the CI label Jul 17, 2024
RondeauG
RondeauG approved these changes Jul 18, 2024
View reviewed changes
tests/test_hydrotel.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the approved Approved for additional tests label Jul 18, 2024
@Zeitsperre Zeitsperre merged commit 8a6bdf9 into main Jul 18, 2024
20 checks passed
@Zeitsperre Zeitsperre deleted the adjustments branch July 18, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RondeauG RondeauG RondeauG approved these changes

Assignees
No one assigned
Labels
approved Approved for additional tests CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeitsperre @RondeauG