Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat meteo for Hydrotel #185

Merged
merged 18 commits into from
Oct 4, 2024
Merged

Reformat meteo for Hydrotel #185

merged 18 commits into from
Oct 4, 2024

Conversation

RondeauG
Copy link
Collaborator

@RondeauG RondeauG commented Aug 26, 2024 •
edited
Loading

Pull Request Checklist:

  • This PR addresses an already opened issue (for bug fixes / features)
    • This PR fixes #xyz
  • (If applicable) Documentation has been added / updated (for bug fixes / features).
  • (If applicable) Tests have been added.
  • CHANGELOG.rst has been updated (with summary of main changes).
    • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

  • New function xhydro.modelling.format_input to format CF-compliant input data for hydrological models (currently only supports Hydrotel).

Does this PR introduce a breaking change?

  • No.

Other information:

@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added notebooks Run tests against notebooks docs labels Aug 29, 2024
@RondeauG RondeauG marked this pull request as ready for review August 29, 2024 18:15
@github-actions github-actions bot added the approved Approved for additional tests label Oct 2, 2024
@RondeauG RondeauG merged commit 1c7c54b into main Oct 4, 2024
28 checks passed
@RondeauG RondeauG deleted the hydrotel_met branch October 4, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-malenfant c-malenfant c-malenfant approved these changes

@essicolo essicolo essicolo approved these changes

@JPelletierDumont JPelletierDumont Awaiting requested review from JPelletierDumont

Assignees
No one assigned
Labels
approved Approved for additional tests docs notebooks Run tests against notebooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RondeauG @essicolo @c-malenfant @Zeitsperre