Add notebooks label to pull requests when notebooks are modified #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
10 tasks
sebastienlanglois
added a commit
that referenced
this pull request
Mar 12, 2024
…ilds (#61) <!-- Please ensure the PR fulfills the following requirements! --> <!-- If this is your first PR, make sure to add your details to the AUTHORS.rst! --> ### Pull Request Checklist: - [x] This PR addresses an already opened issue (for bug fixes / features) - This PR fixes #60 - [x] (If applicable) Documentation has been added / updated (for bug fixes / features). - [X] (If applicable) Tests have been added. - [X] CHANGES.rst has been updated (with summary of main changes). - [X] Link to issue (:issue:`number`) and pull request (:pull:`number`) has been added. ### What kind of change does this PR introduce? This PR adds a GIS module for usual geospatial operations that are common in hydrology such a watershed delineation, watershed properties extraction, etc. It adapts the work that's been done in [ravenpy](https://ravenpy.readthedocs.io/) while also adding some new functionalities. **Watershed Delineation** - [x] Support concurrent delineation of multiple watersheds simultaneously. - [X] Enable access to official watershed polygons (shapefiles/geojson/geoparquet) from authoritative sources (DEH, HYDAT, USGS, HQ, etc.) —implemented collaboratively with xdatasets. **Physiographic Variable (or others) Extraction** - [x] Support simultaneous extraction of physiographic variables across multiple watersheds. - [X] Facilitate the extraction of variables present in STAC catalogs (e.g., Planetary Computer). - [X] Implement extraction considering pixel weighting rather than an "all_touched" approach, as this can significantly impact final results —implemented collaboratively with xdatasets. ### Does this PR introduce a breaking change? No ### Other information: This PR also integrates the changes from #65 and #68
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist:
number) and pull request (:pull:number) has been added.What kind of change does this PR introduce?
labeler.ymlto the pull requests so that modifications to any notebooks found underdocs/notebookswill add a "notebooks" label to the pull request.Test Notebooksjob that triggers activation when a pull request has thenotebookslabel.Does this PR introduce a breaking change?
No.
Other information:
actions/labeleris an officially-supported GitHub Action. Nevertheless, since it requirespull_request_targetin order to run properly, permissions have been constrained and security is hardened.