Optimal interpolation

[Mayetea]

Pull Request Checklist:

• This PR addresses an already opened issue (for bug fixes / features)
  • This PR fixes #xyz
• (If applicable) Documentation has been added / updated (for bug fixes / features).
• (If applicable) Tests have been added.
• CHANGES.rst has been updated (with summary of main changes).
  • Link to issue (:issue:number) and pull request (:pull:number) has been added.

What kind of change does this PR introduce?

Ajout d'outils pour l'interpolation optimale dans xhydro.

• Outil de validation croisée de fichiers Hydrotel contenant des débits observés et des débits simulés
• Outil de comparaison entre l'interpolation et les débits fournis

Does this PR introduce a breaking change?

No.

Other information:

Je n'ai pas modifié le fichier changes.rst, puisque je n'étais pas sur de ce que je devais y mettre.

[github-actions]

Welcome, new contributor!

It appears that this is your first Pull Request. To give credit where it's due, we ask that you add your information to the AUTHORS.rst and .zenodo.json:

• The relevant author information has been added to AUTHORS.rst and .zenodo.json.

Please make sure you've read our contributing guide. We look forward to reviewing your Pull Request shortly ✨

[RondeauG]

@Mayetea PTI, tu peux faire pre-commit install dans ton répertoire local de xhydro pour activer les fonctionnalités de pre-commit et régler les problèmes de formatage. C'est ce qui fait planter les premiers checkups.

[RondeauG]

On s'approche !

[RondeauG]

Quelques commentaires mineurs, mais sinon ça me semble prêt ! Merci pour le gros refactoring, ça me semble avoir été pas mal de job.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[richardarsenault]

@Zeitsperre

The testdata fetching function need to be rewritten to work with the new system. I'd suggest to first add them into the main branch of hydrologie/xhydro-testdata, then add the necessary info to registry.txt before fetching the files with DEVEREAUX.fetch("..."). Let me know if you need further guidance on how to do this.

Does this still apply, with the new system with pooch?

[Zeitsperre]

@richardarsenault

Not anymore. The fetching code has migrated to pooch which is good enough for right now. A next step would be to implement the mechanism I detailed, but that will come later.

For context, the goal of pooch and the catalogue is to reduce the potential for breakage when fetching remote files, and to reduce the duplicated code and maintenance required (the original testdata fetching code is the same in at least five projects we maintain). Getting that to work with things like pytest-xdist (for asynchronous testing) is really finicky as well. This is already a major improvement.

[richardarsenault]

OK great, thanks, great to hear!