[#57] upgrade to pydantic v2 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion data object related APIs
…hare/hsclient into 57-upgrade-to-pydantic-v2
|
There were a couple of changes I had to make to hydroshare for the upgrade, just updating from json/dict to model_dump/model_dump_json. There was also a formatting change with Url types that appends a / at the end of the urls. I'm running a PR build for the test suite now, it should wrap up in an hour or so and then we'll be good with merging and releasing hsmodels. http://ci.hydroshare.org:8080/job/hydroshare-pull-requests/7159/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: The 2 tests that are currently failing is due to this bug (hydroshare/hydroshare#5204) in hydroshare. There is a PR in hydroshare to fix this bug and should be fixed as part of release 2.11.