[#5286] Add explicit rule engine instance to irule invocation.

[cbcunc]

Pull Request Checklist:

• Positive Test Case Written by Dev

pre-existing: https://github.com/hydroshare/hydroshare/blob/master/hs_core/tests/api/native/test_bagit.py#L16

• Automated Testing

• Sufficient User and Developer Documentation

• Passing Jenkins Build

• Peer Code review and approval

Positive Test Case

1. pre-existing: https://github.com/hydroshare/hydroshare/blob/master/hs_core/tests/api/native/test_bagit.py#L16

[trel]

I think this will do exactly what you are looking for.

Does it pass/run successfully?

[devincowan]

@cbcunc looks good thank you
just need to fix the linting
http://ci.hydroshare.org:8080/job/hydroshare-pull-requests/6975/artifact/pylint.out/*view*/

[devincowan]

I pushed the linting fix just to get the PR build running

[cbcunc]

@trel All the tests that invoke the rule fail with

django_irods.icommands.SessionException: (SessionException(...), "Error processing IRODS request: -1. stderr follows:\n\nb' ERROR: parseMsInputParam: inpParam hydroshare/irods/ruleGenerateBagIt_HS.r format error\\n ERROR: Invalid input parameter list specification\\nUse -h for help.\\n'")

and I am not understanding why.

[trel]

Ah, I think it expects each space-delimited argument to irule to be a separate parameter to self.session.run()...

Like this...

self.session.run("irule", None, "-r", "irods_rule_engine_plugin-irods_rule_language-instance", "-F",
                         rule_name, input_path, input_resource)

[cbcunc]

Possibly. I'll try that. I'm curious that the last three arguments aren't positional. self.session.run is a call into django_irods that Jason wrote.

[cbcunc]

Ah, yeah, we already tried that in the very first commit. The arguments are positional. 99fa4f0

[cbcunc]

I will try it again, though, as it looks like it should work:

hydroshare/django_irods/icommands.py

Line 152 in 874d823

def run(self, icommand, data=None, *args):

[trel]

Right, there are other calls in that file that have differing number of arguments.

[cbcunc]

@trel So now that each we're back to each space-delimited argument to irule is a separate parameter, this error on every every test involving this generated rule. @devincowan Can you confirm that this error has not been occurring to block PRs previously?

Error Message

(SessionException(...), "Error processing IRODS request: -1. stderr follows:\n\nb' ERROR: Cannot open input file  . errno = 2\\n'")

Stacktrace

Traceback (most recent call last):
  File "/hydroshare/hs_core/hydroshare/hs_bagit.py", line 102, in create_bagit_files_by_irods
    istorage.runBagitRule(bagit_rule_file, bagit_input_path, bagit_input_resource)
  File "/hydroshare/django_irods/storage.py", line 135, in runBagitRule
    self.session.run("irule", None, "-r", "irods_rule_engine_plugin-irods_rule_language-instance", "-F ",
  File "/hydroshare/django_irods/icommands.py", line 182, in run
    raise SessionException(proc.returncode, stdout, stderr)
django_irods.icommands.SessionException: (SessionException(...), "Error processing IRODS request: 1. stderr follows:\n\nb' ERROR: Cannot open input file  . errno = 2\\n'")

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/usr/local/lib/python3.9/unittest/case.py", line 59, in testPartExecutor
    yield
  File "/usr/local/lib/python3.9/unittest/case.py", line 592, in run
    self._callTestMethod(testMethod)
  File "/usr/local/lib/python3.9/unittest/case.py", line 550, in _callTestMethod
    method()
  File "/hydroshare/hs_core/tests/api/native/test_bagit.py", line 54, in test_bag_creation_and_deletion
    status = create_bag_by_irods(self.test_res.short_id)
  File "/usr/local/lib/python3.9/site-packages/celery/local.py", line 188, in __call__
    return self._get_current_object()(*a, **kw)
  File "/usr/local/lib/python3.9/site-packages/celery/app/task.py", line 392, in __call__
    return self.run(*args, **kwargs)
  File "/hydroshare/hs_core/tasks.py", line 766, in create_bag_by_irods
    create_bagit_files_by_irods(res, istorage)
  File "/hydroshare/hs_core/hydroshare/hs_bagit.py", line 109, in create_bagit_files_by_irods
    raise SessionException(-1, '', ex.stderr)
django_irods.icommands.SessionException: (SessionException(...), "Error processing IRODS request: -1. stderr follows:\n\nb' ERROR: Cannot open input file  . errno = 2\\n'")

[devincowan]

@cbcunc I can confirm that this error has not been blocking PRs recently

[trel]

errno 2 is No such file or directory

so... which file doesn't exist?

[devincowan]

closing as no longer necessary after 2.14.1 release of hydroshare, we no longer use the irods microservice for quota tracking in the datazone