-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Db connection pooling dev #5662
base: develop
Are you sure you want to change the base?
Conversation
@MSDrao looks like you have some broken tests. I will review once those are resolved. |
Also noting that this work will take some tooling to get pgbouncer running in k8s |
@@ -43,6 +43,26 @@ services: | |||
- "54322:5432" | |||
stdin_open: true | |||
tty: true | |||
pgbouncer: | |||
image: edoburu/pgbouncer:latest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just curious, why not https://hub.docker.com/r/bitnami/pgbouncer/ ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good!
next step is some load testing...
@MSDrao I committed your locustfile.py here: |
12781d1
to
0469853
Compare
Posting some initial load tests here...not looking promising at this point but I'm going to keep at it.
Hope to show something more promising in a bit... UPDATE with some additional tests:
There isn't a huge benefit here, but it does look like there is some improvement (pgbouncer test allows higher # of users before failure) |
ahhh here we go! ☝️ we can get to much higher numbers of users before getting 502s and we can also achieve significantly higher RPS! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after load testing on dev-1 I think this looks good!
Pull Request Checklist:
Positive Test Case