Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #71

Merged
merged 39 commits into from
Feb 13, 2023
Merged

Documentation #71

merged 39 commits into from
Feb 13, 2023

Conversation

alvesisaque
Copy link
Contributor

Motivation

Updates all project documentation, including readme and more general structures

Changes

  • README.md
  • code documentation
  • update page documentation

Copy link
Contributor

@apmt apmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.a I guess the branch name could follow the contribuition guilines x/issue_name, where x represents the issue

@@ -21,7 +39,19 @@ def __init__(self, model_file=None, n_estimators=100, max_depth=None, random_sta
self.random_state = random_state
self.model = RandomForestClassifier(n_estimators=self.n_estimators, max_depth=self.max_depth, random_state=self.random_state)

def train_and_get_scores(self, df, concatened_column_name, all_features_columns, test_size=0.3):
def train_and_get_scores(self, df, concatened_column_name, all_features_columns, test_size=0.3):
Copy link
Contributor

@apmt apmt Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.b need to undo the identation changes in order to run this code and pass the tests

@apmt
Copy link
Contributor

apmt commented Feb 8, 2023

  1. Some links in the documentation are not working, like:

@apmt
Copy link
Contributor

apmt commented Feb 8, 2023

  1. I guess would be a good thing to try to fix the code blocs examples format, like in here

@apmt
Copy link
Contributor

apmt commented Feb 8, 2023

  1. We could also try to set this sphinix param to True, in order to test if this would better format this part of the docstring:
:param df: Dataframe to extract word embedding features from.
:type df: pandas.DataFrame
:param column_name: Name of the column in the dataframe that contains the text data to extract features from.
:type column_name: str
:param normalize: Indicates whether to normalize the word embedding feature columns. Default is True.
:type normalize: bool, optional

@alvesisaque alvesisaque temporarily deployed to github-pages February 10, 2023 19:05 — with GitHub Pages Inactive
@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Base: 79.89% // Head: 79.89% // No change to project coverage 👍

Coverage data is based on head (2fc29c9) compared to base (42488ee).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #71   +/-   ##
=======================================
  Coverage   79.89%   79.89%           
=======================================
  Files          31       31           
  Lines         965      965           
=======================================
  Hits          771      771           
  Misses        194      194           
Impacted Files Coverage Δ
hygia/data_pipeline/annotate_data/annotate_data.py 90.00% <ø> (ø)
hygia/data_pipeline/augment_data/augment_data.py 96.15% <ø> (ø)
...ipeline/feature_engineering/feature_engineering.py 100.00% <ø> (ø)
...gia/data_pipeline/feature_engineering/key_smash.py 94.33% <ø> (ø)
hygia/data_pipeline/feature_engineering/regex.py 83.60% <ø> (ø)
...ata_pipeline/feature_engineering/word_embedding.py 70.00% <ø> (ø)
hygia/data_pipeline/model/random_forest.py 34.17% <ø> (ø)
...data_pipeline/pre_process_data/pre_process_data.py 59.09% <ø> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alvesisaque alvesisaque temporarily deployed to github-pages February 10, 2023 19:54 — with GitHub Pages Inactive
@alvesisaque alvesisaque temporarily deployed to github-pages February 13, 2023 12:56 — with GitHub Pages Inactive
Copy link
Contributor

@Bruno-Felix Bruno-Felix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Show!!

@Bruno-Felix Bruno-Felix merged commit 2183936 into main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants