Skip to content
This repository has been archived by the owner on Oct 2, 2023. It is now read-only.

removed authentication for deploy script capture #175

Merged
merged 1 commit into from
Nov 16, 2020
Merged

removed authentication for deploy script capture #175

merged 1 commit into from
Nov 16, 2020

Conversation

rvema
Copy link
Contributor

@rvema rvema commented Nov 16, 2020

  • Removed authentication for /v3/deploy.
  • Commented the persistence for /v3/deploy to be redesigned shortly.

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Nov 16, 2020
nireeshT
nireeshT approved these changes Nov 16, 2020
View reviewed changes
Copy link
Collaborator

@nireeshT nireeshT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Nov 16, 2020
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell C 2 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_275) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11.
Read more here

@rvema rvema merged commit 2ebf866 into master Nov 16, 2020
@trafico-bot trafico-bot bot added the ✨ Merged Pull Request has been merged successfully label Nov 16, 2020
@rvema rvema deleted the disable-deploy branch November 16, 2020 03:28
@trafico-bot trafico-bot bot removed the ✅ Approved Pull Request has been approved and can be merged label Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nireeshT nireeshT nireeshT approved these changes

Assignees
No one assigned
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvema @nireeshT