Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Gatsby v4 #206

Merged
merged 5 commits into from
Sep 14, 2021
Merged

feat: add support for Gatsby v4 #206

merged 5 commits into from
Sep 14, 2021

Conversation

jpedroschmitz
Copy link
Contributor

This PR adds support for Gatsby v4.

Looking into the migration guide, we don't have any relevant updates to do in the package.

We also need to publish it under the next tag on npm.

@jpedroschmitz jpedroschmitz self-assigned this Sep 9, 2021
@gatsby-cloud
Copy link

gatsby-cloud bot commented Sep 9, 2021

Gatsby Cloud Build Report

gatsby-source-graphcms

🎉 Your build was successful! See the Deploy preview here.

Build Details

View the build logs here.

🕐 Build time: 3m

Performance

Lighthouse report

Metric Score
Performance 💚 100
Accessibility 💚 93
Best Practices 💚 100
SEO 🔶 75

🔗 View full report

@jpedroschmitz
Copy link
Contributor Author

jpedroschmitz commented Sep 9, 2021

The build is failing because of the Node.js version.
Gatsby v4 requires Node.js >=14.15. The cloud project still uses version 12 - I couldn't find a place to change it.

@jpedroschmitz jpedroschmitz force-pushed the feat/gatsby-v4 branch 2 times, most recently from 5139f33 to d058518 Compare September 14, 2021 13:41
@jpedroschmitz jpedroschmitz changed the base branch from next to main September 14, 2021 14:01
notrab
notrab previously approved these changes Sep 14, 2021
@jpedroschmitz
Copy link
Contributor Author

It's building correctly! The bot hasn't updated the status.

@jpedroschmitz jpedroschmitz changed the base branch from main to next September 14, 2021 14:30
@jpedroschmitz jpedroschmitz merged commit 73af00b into next Sep 14, 2021
@jpedroschmitz jpedroschmitz deleted the feat/gatsby-v4 branch September 14, 2021 14:30
@github-actions
Copy link

🎉 This PR is included in version 2.7.0-next.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@notrab
Copy link
Contributor

notrab commented Sep 14, 2021

🤖

notrab pushed a commit that referenced this pull request Jan 11, 2022
notrab added a commit that referenced this pull request Jan 11, 2022
* feat: add support for Gatsby v4 (#206)

* ci: change node version to 14

* fix: remove return null (#215)

* fix: revert remove return null 215

This reverts commit 4939c84.

* fix: allow nullable gatsbyImageData (#217)

* chore: add additional fragments

* fix: use newer dependencies

* chore: use github actions v2

* fix: temp explicit rich text typenames

* docs: update readme

* fix: detect RichText automatically to create types

* docs(README): add note on Bad Request

* chore: cleanup demo Product fragment

* docs: add note about gatsby v4 (#207)

* feat: add support for Gatsby v4 (#206)

* docs(README): update install instructions

* fix: merge conflict

* docs(README): contributing note

* chore: fix contributors rc

Co-authored-by: João Pedro Schmitz <oi@joaopedro.cc>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants