feat(html-to-slate-ast): forward link attributes

[notrab]

No description provided.

[changeset-bot]

🦋 Changeset detected

Latest commit: c491332

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@graphcms/html-to-slate-ast	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
packages/react-renderer/dist/rich-text-react-renderer.cjs.production.min.js	4.37 KB (0%)
packages/react-renderer/dist/rich-text-react-renderer.esm.js	4.31 KB (0%)
packages/types/dist/rich-text-types.cjs.production.min.js	51 B (0%)
packages/types/dist/rich-text-types.esm.js	64 B (0%)

[notrab]

@jpedroschmitz I'm not sure if I got the changeset stuff right - I'm used to semantic-release automated the semver for me 😅

[ronakganatra]

🍰

[ronakganatra]

Let @jpedroschmitz approve as well before merging.

[notrab]

@ronakganatra let's let @okjulian & team review 😅

[jpedroschmitz]

Looks great! Perhaps we also will need to add these conditionals to other elements with custom props, such as the IFrame, video, image...

[notrab]

@jpedroschmitz yep I thought as much when adding these. I’ll add these in a separate PR.

[wozzer72]

@notrab Hey Jamie. This looks beautiful.

[notrab]

@wozzer72 I'll add the following for iframe support in another PR (as well as another fix for something):

IFRAME: (el) => ({
    type: 'iframe',
    url: el.getAttribute('src'),
    ...(el.hasAttribute('title') && { title: el.getAttribute('title') }),
    ...(el.hasAttribute('width') && {
      width: parseInt(el.getAttribute('width') as keyof number, 10),
    }),
    ...(el.hasAttribute('height') && {
      height: parseInt(el.getAttribute('height') as keyof number, 10),
    }),
  }),

[oddtinker]

Looks good! I'd wait for @okjulian 's review before merging.