Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce inline embeds #52

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Conversation

oddtinker
Copy link
Contributor

Updates EmbedProps type and adds a test for custom rendering of an inline embed.

@oddtinker oddtinker self-assigned this Dec 6, 2021
@changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2021

🦋 Changeset detected

Latest commit: 8f71ac7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphcms/rich-text-types Minor
@graphcms/html-to-slate-ast Patch
@graphcms/rich-text-react-renderer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@oddtinker oddtinker added the react-renderer Issues and PR's related to @graphcms/rich-text-react-renderer label Dec 6, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2021

size-limit report 📦

Path Size
packages/react-renderer/dist/rich-text-react-renderer.cjs.production.min.js 4.97 KB (0%)
packages/react-renderer/dist/rich-text-react-renderer.esm.js 4.94 KB (0%)
packages/types/dist/rich-text-types.cjs.production.min.js 51 B (0%)
packages/types/dist/rich-text-types.esm.js 64 B (0%)

Copy link
Member

@jpedroschmitz jpedroschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left only two small comments around the changesets. Other than that, it's looking good =D

.changeset/little-colts-learn.md Outdated Show resolved Hide resolved
.changeset/spotty-dogs-wonder.md Outdated Show resolved Hide resolved
Copy link
Member

@jpedroschmitz jpedroschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oddtinker
Copy link
Contributor Author

@jpedroschmitz I addressed your feedback 👍

@jpedroschmitz
Copy link
Member

Same time 😂

@oddtinker oddtinker merged commit bc9e612 into main Dec 7, 2021
@github-actions github-actions bot mentioned this pull request Dec 7, 2021
@feychenie feychenie deleted the larisa/update-types-inline-embeds branch January 6, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
react-renderer Issues and PR's related to @graphcms/rich-text-react-renderer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants