Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anmol/ux 185 html ast plugin improvements for bandai #93

Merged

Conversation

anmolarora1
Copy link
Contributor

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2022

🦋 Changeset detected

Latest commit: 37b3d32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphcms/html-to-slate-ast Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@linear
Copy link

linear bot commented Aug 16, 2022

UX-185 HTML-AST plugin improvements for Bandai

Shaping Doc - https://www.notion.so/graphcms/HTML-AST-plugin-improvement-for-Bandai-d19ab73d6c6542aba34ce797b5e70bc9

The issue at hand is that Bandai has several HTML elements that are not supported by the plugin. The two cases that we’re going to be solving are:

  1. Importing iframes in hygraph. At the moment, iframes cannot be imported into Hygraph.
  2. Importing elements inside tables. At the moment, when you import a table with bold text inside it, the text is not migrated as bold.

Definition of done

  1. Iframes - the task is considered done when a user is able to use the html-ast plugin to import an iframe element into the rich text field in Hygraph. The content of the iframe (e.g. a YouTube video) should be visible in the Rich Text field. A user should be able to play the video (or interact with a different element), change the iframe’s dimensions, and delete the iframe. The imported iframes should have a default appearance.
  2. Bold text in tables - the task is considered done when a user is able to use the html-ast plugin to import a table with bold text, and the bold text remains bold in Hygraph’s rich text field.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 16, 2022

size-limit report 📦

Path Size
packages/react-renderer/dist/rich-text-react-renderer.cjs.production.min.js 5.27 KB (0%)
packages/react-renderer/dist/rich-text-react-renderer.esm.js 5.21 KB (0%)
packages/html-renderer/dist/rich-text-html-renderer.cjs.production.min.js 2.71 KB (0%)
packages/html-renderer/dist/rich-text-html-renderer.esm.js 2.66 KB (0%)

@anmolarora1 anmolarora1 marked this pull request as ready for review August 16, 2022 12:07
Copy link
Member

@jpedroschmitz jpedroschmitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmolarora1 anmolarora1 merged commit f3c9e30 into main Aug 17, 2022
@github-actions github-actions bot mentioned this pull request Aug 17, 2022
@jpedroschmitz jpedroschmitz deleted the anmol/ux-185-html-ast-plugin-improvements-for-bandai branch May 23, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants