Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix terminal emulator detection #2

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fix terminal emulator detection #2

merged 1 commit into from
Apr 25, 2022

Conversation

coloursofnoise
Copy link
Contributor

Adds hyfetch to the list of ignored process names when retrieving the terminal emulator.

Terminal detection works by recursively checking parent processes until the result isn't $SHELL, *sh, screen or tmux. [1]

@hykilpikonna hykilpikonna merged commit 7f949fe into hykilpikonna:master Apr 25, 2022
@hykilpikonna
Copy link
Owner

hykilpikonna commented Apr 25, 2022 •
edited
Loading

Just saw this. Thank you so much!!!

The update is released in v1.0.5

teohhanhui added a commit to teohhanhui/hyfetch that referenced this pull request Jun 27, 2024
@teohhanhui
Merge pull request hykilpikonna#2 from teohhanhui/riir
6e0e3fd 
Get distro name from neofetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@coloursofnoise @hykilpikonna