Handle closures with environment for autoclosures #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucteo
commented
Dec 6, 2023
| // &counter += 1 | ||
| // return r | ||
| // }) | ||
| // logic2(withDelayed: r.abs()) |
There was a problem hiding this comment.
@kyouko-taiga : I would need your help understanding why the code generator inserts a call here to a function that it doesn't exist.
There was a problem hiding this comment.
It's a bit hard to tell on the source code only, as I didn't write the logic for lowering autoclosures myself. Can you tell what the emitter believes this function should be?
If you print the IR you should at least see a semi-helpful description of the FunctionReference being applied.
|
@lucteo please either move this PR forward or close it; thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.