Skip to content

Commit

Permalink
Accept that we haven't run pypy3 tests in months
Browse files Browse the repository at this point in the history
We have to add cogCheck to the envlist so it's run in CI.

I've added it before cog, so every re-render is loudly announced to the user.
  • Loading branch information
hynek committed Nov 20, 2021
1 parent e0adf4d commit 7fdd847
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
runs-on: "ubuntu-latest"
strategy:
matrix:
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10", "pypy-3.7"]
python-version: ["3.6", "3.7", "3.8", "3.9", "3.10"]

steps:
- uses: "actions/checkout@v2"
Expand Down
3 changes: 2 additions & 1 deletion README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ Project Information

We collect useful third-party extension in `our wiki <https://github.com/hynek/structlog/wiki/Third-party-Extensions>`_.

``structlog`` targets Python 3.6 and later; including PyPy3.
``structlog`` targets Python 3.6 and later.
PyPy3 is known to work, but is not tested anymore.


``structlog`` for Enterprise
Expand Down
2 changes: 1 addition & 1 deletion docs/loggers.rst
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ As you can see, it accepts one mandatory and a few optional arguments:
The class to save your context in.
Particularly useful for `thread-local context storage <thread-local>`.

Since Python 3.6+ and PyPy have ordered dictionaries, the default is a plain `dict`.
Since all supported Python versions have ordered dictionaries, the default is a plain `dict`.

Additionally, the following arguments are allowed too:

Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -299,7 +299,8 @@ Project Information
We collect useful third-party extension in `our wiki <https://github.com/hynek/structlog/wiki/Third-party-Extensions>`_.
``structlog`` targets Python 3.6 and later; including PyPy3.
``structlog`` targets Python 3.6 and later.
PyPy3 is known to work, but is not tested anymore.
``structlog`` for Enterprise
Expand Down
2 changes: 1 addition & 1 deletion tests/test_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ class Foo(metaclass=abc.ABCMeta):

def test_default_context_class():
"""
Default context class is dict on Python 3.6+ and PyPy
Default context class is dict.
"""
assert dict is _BUILTIN_DEFAULT_CONTEXT_CLASS

Expand Down
5 changes: 1 addition & 4 deletions tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,10 @@ python =
3.8: py38, docs
3.9: py39, mypy
3.10: py310, cogCheck
pypy-3: pypy3


[tox]
# Running tests on pypy3 is very slow, we don't need it for coverage, and it's
# unlikely it'll ever break. Therefore, we only run it in CI -- just in case.
envlist = pre-commit,mypy,cog,{py36,py37,py38,py39,py310}-threads,py39-greenlets,py39-colorama,py310-be,py310-rich,docs,pypi-description,coverage-report
envlist = pre-commit,mypy,cogCheck,cog,{py36,py37,py38,py39,py310}-threads,py39-greenlets,py39-colorama,py310-be,py310-rich,docs,pypi-description,coverage-report
isolated_build = True


Expand Down

0 comments on commit 7fdd847

Please sign in to comment.