Map method name in capture_logs as well #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
@hynek could you please cut a new minor release with this fix? been waiting for this fix to get my CI to pass 😄 |
iaindillingham
added a commit
to opensafely-core/job-server
that referenced
this pull request
Jul 23, 2024
The `log_output` fixture (`tests/conftest.py`) returns an instance of `structlog.testing.LogCapture`. structlog v24.3.0 changed the behaviour of `LogCapture`, via the `map_method_name` function, to map the `exception` log level to the `error` log level (hynek/structlog#628). This change broke `test_post_error`. Here, we simply accept that decision, and update `test_post_error`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The fix of mapping exception to error log level doesn't work in capture_log during test
See #584 (comment)