Skip to content
This repository has been archived by the owner on Aug 14, 2021. It is now read-only.

Create reaction resolver #76

Merged
merged 5 commits into from
Apr 26, 2020
Merged

Create reaction resolver #76

merged 5 commits into from
Apr 26, 2020

Conversation

daadaadaah
Copy link
Contributor

@daadaadaah daadaadaah commented Mar 22, 2020

Description

Create model, schema and resolver for Reaction

Related Pullrequest

#37

Tests

Done

CheckList

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • Run yarn lint && yarn tsc
  • I am willing to follow-up on review comments in a timely manner.

@codecov
Copy link

codecov bot commented Mar 22, 2020

Codecov Report

Merging #76 into master will increase coverage by 1.10%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   67.32%   68.42%   +1.10%     
==========================================
  Files          29       31       +2     
  Lines         658      681      +23     
  Branches       52       52              
==========================================
+ Hits          443      466      +23     
  Misses        201      201              
  Partials       14       14              

@daadaadaah
Copy link
Contributor Author

@hyochan
Please, Review my PR!

@hyochan
Copy link
Owner

hyochan commented Mar 23, 2020

It'd be good if we can see it all together on Sunday :) Hope you share small demo either.

Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyochan hyochan merged commit 6fbdf73 into hyochan:master Apr 26, 2020
This was referenced May 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants