Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changing subscriptions on Android broken #1128

Closed
M46N3 opened this issue Sep 25, 2020 · 0 comments · Fixed by #1129
Closed

Changing subscriptions on Android broken #1128

M46N3 opened this issue Sep 25, 2020 · 0 comments · Fixed by #1129
Labels
🤖 android Related to android 🐛 bug Something isn't working

Comments

@M46N3
Copy link
Contributor

M46N3 commented Sep 25, 2020

Version of react-native-iap

4.6.1

Version of react-native

0.63.2

Platforms you faced the error (IOS or Android or both?)

Android

Expected behavior

When changing from one subscription to another (from yearly to monthly etc.) it should handle the old subscription properly according to the set prorationModeAndroid .

Actual behavior

New subscription is created without anything happening to the existing subscription.

Tested environment (Emulator? Real Device?)

Emulator and device.

Steps to reproduce the behavior

  • Launch app with at least 2 subscriptions available on Google Play
  • Subscribe to one of the subscriptions
  • Subscribe to second subscription
  • Watch both subscriptions be active at the same time
@M46N3 M46N3 mentioned this issue Sep 25, 2020
Merged
hyochan pushed a commit that referenced this issue Sep 25, 2020
@M46N3
Fix changing subscriptions on Android (#1129)
d5785e5 
Added the new way to upgrade/downgrade from a previous subscription when subscribing to a new one on Android. Calls setOldSku as described in [Android docs](https://developer.android.com/reference/com/android/billingclient/api/BillingFlowParams.Builder#setOldSku(java.lang.String,%20java.lang.String))

This PR fixes #1128
@hyochan hyochan added 🤖 android Related to android 🐛 bug Something isn't working labels Sep 26, 2020
@prathasaxena prathasaxena mentioned this issue Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 android Related to android 🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix changing subscriptions on Android M46N3/react-native-iap
2 participants
@hyochan @M46N3