Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Remove buildToolsVersion #1358

Merged
merged 1 commit into from
May 28, 2021
Merged

[Android] Remove buildToolsVersion #1358

merged 1 commit into from
May 28, 2021

Conversation

dulmandakh
Copy link
Contributor

Setting buildToolsVersion is no longer recommended, it'll default to Android Gradle Plugin defaults. It makes DX worse by requiring multiple versions of build tools by various dependencies require various versions.

remove buildToolsVersion
@hyochan hyochan added 🍗 enhancement New feature or request 👷‍♀️ build Build issue 🤖 android Related to android labels May 28, 2021
@hyochan hyochan changed the title remove buildToolsVersion [Android] Remove buildToolsVersion May 28, 2021
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hyochan hyochan merged commit 09bf8cc into hyochan:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 android Related to android 👷‍♀️ build Build issue 🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants