Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleans up Native Module checks #1374

Merged
merged 8 commits into from
Jun 15, 2021

Conversation

andresesfm
Copy link
Contributor

@andresesfm andresesfm commented Jun 12, 2021

Removed a lot of code that is redundant now that we have better split the Android Native modules

@hyochan hyochan added the 🍗 enhancement New feature or request label Jun 14, 2021
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates 🙏. However I am seeing lots of linting errors so far.

image

Can you please pull your sourcecode and run yarn lint? I've just found that the lint script should be updated although ide can grab it.

README.md Outdated Show resolved Hide resolved
src/iap.ts Show resolved Hide resolved
@hyochan hyochan force-pushed the master branch 6 times, most recently from 880bb7a to 6ae8d24 Compare June 14, 2021 08:14
@andresesfm andresesfm requested a review from hyochan June 15, 2021 00:47
hyochan pushed a commit that referenced this pull request Jun 15, 2021
Ignore android build for now since this is going to be fixed in #1374
Copy link
Owner

@hyochan hyochan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again! Thanks for everything @andresesfm.

Please submit an expense of $80 for a small gift in https://opencollective.com/react-native-iap which includes your previous PRs.

@hyochan hyochan merged commit 5ac67b3 into hyochan:master Jun 15, 2021
@hyochan
Copy link
Owner

hyochan commented Jun 15, 2021

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍗 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants